Add functionality to Ghommal's lucky penny #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gc
reviewed
Feb 13, 2024
| @@ -297,6 +298,17 @@ export async function degradeItem({ | |||
| const degItem = degradeableItems.find(i => i.item === item); | |||
| if (!degItem) throw new Error('Invalid degradeable item'); | |||
|
|
|||
| // 5% chance to not consume a charge when Ghommal's lucky penny is equipped | |||
There was a problem hiding this comment.
If its a 5% percent chance, we should use percentChance(5)
There was a problem hiding this comment.
Switched it to percentChance(5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
"When equipped, it offers a 5% chance to not use a charge when using items that consume charges (such as jewellery and weapons)." https://oldschool.runescape.wiki/w/Ghommal%27s_lucky_penny
Changes:
Other checks: